Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Drop unneeded cargo-ndk tool from build-test #476

Merged
merged 1 commit into from
May 19, 2024

Commits on May 19, 2024

  1. CI: Drop unneeded cargo-ndk tool from build-test

    A recent borked `cargo-ndk` release [^1] [^2] lead me to investigate
    why we are using a nonstandard tool in our CI in the first place.
    Compiling / build-testing the `ndk` crate does not require any external
    tooling whatsoever nor an SDK setup: this crate is a pure wrapper over
    pre-generated C bindings in the `ndk-sys` crate, which only require
    NDK _libraries_ (and an Android-capable linker) when linking actual
    runnable binaries (typically shared libraries or executables).  And the
    Rust compiler natively supports compiling Rust code for Android targets.
    
    [^1]: https://github.com/rust-mobile/ndk/actions/runs/9149848316
    [^2]: https://togithub.com/bbqsrc/cargo-ndk/pull/135#discussion_r1606097922
    MarijnS95 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7c9fa5f View commit details
    Browse the repository at this point in the history