Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossip storage and relays rank/score #570

Open
yukibtc opened this issue Sep 10, 2024 · 2 comments
Open

Gossip storage and relays rank/score #570

yukibtc opened this issue Sep 10, 2024 · 2 comments
Milestone

Comments

@yukibtc
Copy link
Member

yukibtc commented Sep 10, 2024

  • Add dedicated persistent storage for gossip data
  • Implement a relays rank/score
@reyamir
Copy link
Contributor

reyamir commented Oct 28, 2024

I see a cons of current gossip method is the client is trying connect inbox/outbox relays before query event

// Add outbox relays
for url in broken_down.outbox_urls.into_iter() {
    if self.add_outbox_relay(&url).await? {
        self.connect_relay(url).await?;
    }
}

// Add inbox relays
for url in broken_down.inbox_urls.into_iter() {
    if self.add_inbox_relay(&url).await? {
        self.connect_relay(url).await?;
    }
}

If relay have some errors, client will try reconnect, the fetch events will become very slow. I wonder if when this issue is resolved (gossip storage and relays rank/score implemented). Will this problem be solved too?

@yukibtc
Copy link
Member Author

yukibtc commented Oct 28, 2024

If relay have some errors, client will try reconnect, the fetch events will become very slow.

Yes, this is true but after few attempts the SDK will start skipping unresponsive relays (this in general, not only for gossip). This require some secs so if the relay was just added it will not be skipped.

I wonder if when this issue is resolved (gossip storage and relays rank/score implemented). Will this problem be solved too?

Yeah, partially. I still have to study the best way to implement it. Using a relay score I can ignore the unresponsive relays but for new ones the issue could still persist (if the relays are new, never saw before).

@yukibtc yukibtc modified the milestones: Release v0.37, Release v0.38 Nov 26, 2024
@yukibtc yukibtc modified the milestones: Release v0.38, Release v0.39 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants