Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init some nostr book sections #247

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Init some nostr book sections #247

merged 3 commits into from
Jan 18, 2024

Conversation

rustedmoon
Copy link
Contributor

@rustedmoon rustedmoon commented Jan 12, 2024 •
edited
Loading

Description

Notes to the reviewers

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@rustedmoon rustedmoon marked this pull request as ready for review January 18, 2024 10:53
yukibtc
yukibtc approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0f79694

@yukibtc yukibtc merged commit d461dce into rust-nostr:master Jan 18, 2024
6 checks passed
@rustedmoon rustedmoon deleted the book branch January 18, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukibtc yukibtc yukibtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustedmoon @yukibtc