Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: rename FilterOptions to ReqExitPolicy #692

Merged
merged 1 commit into from
Dec 26, 2024
Merged

pool: rename FilterOptions to ReqExitPolicy #692

merged 1 commit into from
Dec 26, 2024

Conversation

yukibtc
Copy link
Member

@yukibtc yukibtc commented Dec 25, 2024

  • Add ReqExitPolicy
  • Deprecate FilterOptions

@dluvian

@yukibtc
Copy link
Member Author

yukibtc commented Dec 25, 2024

@dluvian I've tried with ReqExitPolicy instead of ExitOptions or CloseOptions because it's a single option/policy and to make it a little bit easier to understand what it is when reading the code. What do you think?

@yukibtc yukibtc marked this pull request as ready for review December 25, 2024 07:50
dluvian
dluvian approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@dluvian dluvian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better name. Thanks for the change

@yukibtc
pool: rename FilterOptions to ReqExitPolicy
7351b86 
Ref #691

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc yukibtc merged commit 7351b86 into master Dec 26, 2024
8 checks passed
@yukibtc yukibtc deleted the req-exit-policy branch December 26, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluvian dluvian dluvian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukibtc @dluvian