pool: auto-close subscription after Duration of no new events
#693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukibtc
force-pushed
the
no-events-timeout
branch
3 times, most recently
from
94167e3 to
35d4c6f
Compare
|
@dluvian what do you think? Should the |
I like |
dluvian
reviewed
Dec 26, 2024
| pub fn timeout(&self, timeout: Option<Duration>) -> Self { | ||
| let mut builder = self.clone(); | ||
| builder.inner = builder.inner.timeout(timeout); | ||
| builder | ||
| } | ||
|
|
||
| /// Automatically close subscription if don't receive any more notifications/events within the duration. |
There was a problem hiding this comment.
Suggested change
| /// Automatically close subscription if don't receive any more notifications/events within the duration. | |
| /// Automatically close subscription if you don't receive any more notifications/events within the duration. |
Suggested change
| /// Automatically close subscription if don't receive any more notifications/events within the duration. | |
| /// Automatically close subscription if no notifications/events are received within the duration. |
| @@ -171,6 +171,12 @@ impl JsSubscribeAutoCloseOptions { | |||
| pub fn timeout(self, timeout: Option<JsDuration>) -> Self { | |||
| self.inner.timeout(timeout.map(|t| *t)).into() | |||
| } | |||
|
|
|||
| /// Automatically close subscription if don't receive any more notifications/events within the duration. | |||
There was a problem hiding this comment.
Suggested change
| /// Automatically close subscription if don't receive any more notifications/events within the duration. | |
| /// Automatically close subscription if you don't receive any more notifications/events within the duration. |
Suggested change
| /// Automatically close subscription if don't receive any more notifications/events within the duration. | |
| /// Automatically close subscription if no notifications/events are received within the duration. |
| pub fn timeout(mut self, timeout: Option<Duration>) -> Self { | ||
| self.timeout = timeout; | ||
| self | ||
| } | ||
|
|
||
| /// Automatically close subscription if don't receive any more notifications/events within the [`Duration`]. |
There was a problem hiding this comment.
Suggested change
| /// Automatically close subscription if don't receive any more notifications/events within the [`Duration`]. | |
| /// Automatically close subscription if you don't receive any more notifications/events within the [`Duration`]. |
Suggested change
| /// Automatically close subscription if don't receive any more notifications/events within the [`Duration`]. | |
| /// Automatically close subscription if no notifications/events are received within the [`Duration`]. |
Add `SubscribeAutoCloseOptions::relative_timeout` Closes #691 Co-authored-by: dluvian <dluvian@proton.me> Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
yukibtc
force-pushed
the
no-events-timeout
branch
from
35d4c6f to
60a10b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.