Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsock: cargo-audit reports that yaml-rust is unmaintained #639

Closed
stefano-garzarella opened this issue Mar 26, 2024 · 3 comments
Closed

Comments

@stefano-garzarella
Copy link
Member

In vhost-device-vsock we use the config crate which now has a dependency that is unmaintained as cargo audit is reporting.

I reported to them here: rust-cli/config-rs#553

For now we don't have a new version available, so we can wait a bit or find an alternative.

@epilys
Copy link
Member

epilys commented Mar 26, 2024

An alternative would be to switch to toml, WDYT?

@stefano-garzarella
Copy link
Member Author

An alternative would be to switch to toml, WDYT?

yeah, I think we can wait a bit to understand their plan, if they will not fix it, we can switch to toml.
Not great as a change, but we are not stable at all, so it could be okay to change our config format.

@stefano-garzarella
Copy link
Member Author

They just switched to yaml-rust2 which seems maintained, so we just need to wait for a new config release. I asked about that.

stefano-garzarella added a commit to stefano-garzarella/vhost-device that referenced this issue Mar 29, 2024
In vhost-device-vsock we use the `config` crate which now has the `yaml-rust`
dependency that is unmaintained as cargo audit is reporting.
See rust-vmm#639

They merged the fix, but for now they don't do a release because they don't
have a maintainer. To get the CI green, let's do this workaround, but before
the next release we have to find a solution.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
vireshk pushed a commit that referenced this issue Apr 2, 2024
In vhost-device-vsock we use the `config` crate which now has the `yaml-rust`
dependency that is unmaintained as cargo audit is reporting.
See #639

They merged the fix, but for now they don't do a release because they don't
have a maintainer. To get the CI green, let's do this workaround, but before
the next release we have to find a solution.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
dorindabassey pushed a commit to dorindabassey/vhost-device that referenced this issue Jul 22, 2024
The config crate, which was previously used in vsock is no longer
maintained. To ensure continued support and improvement, the
figment crate is used as a replacement for configuration management.

Closes rust-vmm#639

Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants