Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-runner back to ctru-rs workspace #178

Merged
merged 3 commits into from
May 3, 2024

Conversation

ian-h-chamberlain
Copy link
Member

@ian-h-chamberlain ian-h-chamberlain commented Apr 20, 2024

Related: #106, rust3ds/actions#5

Simple drop-in from https://github.com/rust3ds/test-runner without any changes except for Cargo.toml

TODO:

  • update README / docs for usage of the test runner crate (maybe also publish to github pages?)
  • wait for CI to be fixed probably

Copy link
Member

@Meziu Meziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, test-runner is coming back home it seems 😄.

Also, just noticed, but the changes made to errorConf (which rightfully set the final size to 3820) aren't being properly checked by the automated bindgen layout tests. Is there a way to override the expected result or avoid testing that type?

@ian-h-chamberlain
Copy link
Member Author

Great, test-runner is coming back home it seems 😄.

Also, just noticed, but the changes made to errorConf (which rightfully set the final size to 3820) aren't being properly checked by the automated bindgen layout tests. Is there a way to override the expected result or avoid testing that type?

Actually, this is interesting — yes, the bindgen test seems to be incorrect (should be 3820), but our generated bindings also seem to be wrong! errorType should have size 2 but it actually has size 4, from what I can tell. I'm not sure if there is a way to forcefully adjust the generated test or make sure it's the right size in practice, but I'll look into it.

My big fear is that this means some of our other binding tests are passing when really they should be failing 😱 so hopefully we can adjust something to make the tests more reliable

@Meziu
Copy link
Member

Meziu commented Apr 23, 2024

Great, all checks are passing now 😃

Let's just fix rust3ds/actions#20 and we can merge this.

@ian-h-chamberlain ian-h-chamberlain merged commit 30d663f into master May 3, 2024
4 checks passed
@ian-h-chamberlain ian-h-chamberlain deleted the feat/restore-test-runner branch May 3, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants