-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uninstaller #109
Add uninstaller #109
Conversation
This is based on the install script, line by line. Will maybe make a nicer menu of everything if I have time and motivation. This PR can be merged as is though.
How about if the user had installed nginx, curl, ufw etc before running install.sh? |
I hear you, the script is destructive. But from my POV, is it better to let the user choose which packages to be uninstalled, or to actually cleanup? Removing Nginx doesn't remove all configs (/etc/nginx would be intact), and curl and ufw can easily be installed again. My view of the regular user is not a power user, rather "I don't know what I'm going so I run a script to make it easier". If you know what you're doing you can remove the things you don't want to be uninstalled by yourself. But yeah, it could be cho6from a list as well. WDYT? |
@dinger1986 do you have any input about this? |
Also, I don't expect Rustdesk to be installed on anything else than a dedicated VPS. |
How about not removing nginx etc by default? You can add a command option to let user choose to delete those in an interactive way. |
Sure, will have another look at it. |
@rustdesk Not tested, but I think this structure is better. What do you think? |
Tested and works! |
@dinger1986 What's your take on this? |
@rustdesk Please squash and merge: |
@rustdesk Ready to merge. |
not sure about the other package managers.
👍 |
rustdesk-server-pro/uninstall.sh Line 173 in 8bc783c
rustdesk-server-pro/uninstall.sh Line 174 in 8bc783c
Duplicate. We may need double check more. |
Copy paste mistake. Will fix and double check the rest. |
Tnanks |
rustdesk#109 (comment) And that the uninstaller rebuilds the boot image is standard behavior, nothing dangerous.
This is based on the install script, line by line.
Will maybe make a nicer menu of everything if I have time and motivation.
This PR can be merged as is though.
EDIT: Made a brand new approach to everything. Will update the install script with the new functions when this is merged.