Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstaller #109

Merged
merged 15 commits into from
Oct 5, 2023
Merged

Add uninstaller #109

merged 15 commits into from
Oct 5, 2023

Conversation

enoch85
Copy link
Contributor

@enoch85 enoch85 commented Oct 3, 2023

This is based on the install script, line by line.

Will maybe make a nicer menu of everything if I have time and motivation.

This PR can be merged as is though.

EDIT: Made a brand new approach to everything. Will update the install script with the new functions when this is merged.

This is based on the install script, line by line.

Will maybe make a nicer menu of everything if I have time and motivation.

This PR can be merged as is though.
@rustdesk
Copy link
Owner

rustdesk commented Oct 4, 2023

How about if the user had installed nginx, curl, ufw etc before running install.sh?

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

How about if the user had installed nginx, curl, ufw etc before running install.sh?

I hear you, the script is destructive.

But from my POV, is it better to let the user choose which packages to be uninstalled, or to actually cleanup?

Removing Nginx doesn't remove all configs (/etc/nginx would be intact), and curl and ufw can easily be installed again.

My view of the regular user is not a power user, rather "I don't know what I'm going so I run a script to make it easier". If you know what you're doing you can remove the things you don't want to be uninstalled by yourself.

But yeah, it could be cho6from a list as well. WDYT?

@rustdesk
Copy link
Owner

rustdesk commented Oct 4, 2023

How about if the user had installed nginx, curl, ufw etc before running install.sh?

@dinger1986 do you have any input about this?

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

Also, I don't expect Rustdesk to be installed on anything else than a dedicated VPS.

@rustdesk
Copy link
Owner

rustdesk commented Oct 4, 2023

How about if the user had installed nginx, curl, ufw etc before running install.sh?

I hear you, the script is destructive.

But from my POV, is it better to let the user choose which packages to be uninstalled, or to actually cleanup?

Removing Nginx doesn't remove all configs (/etc/nginx would be intact), and curl and ufw can easily be installed again.

My view of the regular user is not a power user, rather "I don't know what I'm going so I run a script to make it easier". If you know what you're doing you can remove the things you don't want to be uninstalled by yourself.

But yeah, it could be cho6from a list as well. WDYT?

How about not removing nginx etc by default? You can add a command option to let user choose to delete those in an interactive way.

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

How about if the user had installed nginx, curl, ufw etc before running install.sh?

I hear you, the script is destructive.
But from my POV, is it better to let the user choose which packages to be uninstalled, or to actually cleanup?
Removing Nginx doesn't remove all configs (/etc/nginx would be intact), and curl and ufw can easily be installed again.
My view of the regular user is not a power user, rather "I don't know what I'm going so I run a script to make it easier". If you know what you're doing you can remove the things you don't want to be uninstalled by yourself.
But yeah, it could be cho6from a list as well. WDYT?

How about not removing nginx etc by default? You can add a command option to let user choose to delete those in an interactive way.

Sure, will have another look at it.

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

@rustdesk Not tested, but I think this structure is better. What do you think?

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

Tested and works!

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

@dinger1986 What's your take on this?

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

@rustdesk Please squash and merge:

image

@enoch85 enoch85 mentioned this pull request Oct 4, 2023
@enoch85
Copy link
Contributor Author

enoch85 commented Oct 4, 2023

@rustdesk Ready to merge.

not sure about the other package managers.
@rustdesk
Copy link
Owner

rustdesk commented Oct 5, 2023

👍

@rustdesk rustdesk merged commit 6cf5b6f into rustdesk:main Oct 5, 2023
2 checks passed
@enoch85 enoch85 deleted the patch-2 branch October 5, 2023 06:01
@rustdesk
Copy link
Owner

rustdesk commented Oct 6, 2023

rm -rf /usr/bin/hbbr

rm -rf /usr/bin/hbbr

Duplicate.

We may need double check more.

@enoch85
Copy link
Contributor Author

enoch85 commented Oct 6, 2023

rm -rf /usr/bin/hbbr

rm -rf /usr/bin/hbbr

Duplicate.

We may need double check more.

Copy paste mistake.

Will fix and double check the rest.

@rustdesk
Copy link
Owner

rustdesk commented Oct 6, 2023

Tnanks

@rustdesk
Copy link
Owner

rustdesk commented Oct 7, 2023

Can we remove wget/unzip or make them off by default? since I found wget/unzip are installed on most of servers by default, uninstall.sh make boot image rebuilt, it seems dangerous.

Also there are UFW/NGINX with upper case, but wget etc are lower case, can we make them consistent?
image

enoch85 added a commit to enoch85/rustdesk-server-pro that referenced this pull request Oct 7, 2023
rustdesk#109 (comment)

And that the uninstaller rebuilds the boot image is standard behavior, nothing dangerous.
@enoch85 enoch85 mentioned this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants