Less duplicate code for convert script #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah! that looks great, copying the keys in place before makes most sense so when the services start they are already there |
enoch85
commented
Oct 5, 2023
|
|
||
| # We need to create the new install dir before the migration task, otherwise mv will fail | ||
| mkdir -p "$RUSTDESK_INSTALL_DIR" | ||
|
|
There was a problem hiding this comment.
Note to self: cp -f will overwrite existing files which makes it possible to run this after the installation.
That also means that /opt/rustdesk doesn't have to be removed until after a successful installation.
|
BTW, https://github.com/rustdesk/rustdesk-server-pro/blob/main/restore.sh has the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dinger1986 @rustdesk
Something like this would work. I'm not sure if the "Migration" should happen before or after the new installation though?