Skip to content

Commit

Permalink
more windows fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
aawsome committed Jan 11, 2025
1 parent 8a8cd34 commit e13b75a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
6 changes: 3 additions & 3 deletions crates/core/src/backend/local_destination.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ impl LocalDestination {
#[allow(clippy::unused_self, clippy::unnecessary_wraps)]
pub(crate) fn set_user_group(
&self,
_item: impl AsRef<Path>,
_item: impl AsRef<UnixPath>,
_meta: &Metadata,
) -> LocalDestinationResult<()> {
// https://learn.microsoft.com/en-us/windows/win32/fileio/file-security-and-access-rights
Expand Down Expand Up @@ -370,7 +370,7 @@ impl LocalDestination {
#[allow(clippy::unused_self, clippy::unnecessary_wraps)]
pub(crate) fn set_uid_gid(
&self,
_item: impl AsRef<Path>,
_item: impl AsRef<UnixPath>,
_meta: &Metadata,
) -> LocalDestinationResult<()> {
Ok(())
Expand Down Expand Up @@ -418,7 +418,7 @@ impl LocalDestination {
#[allow(clippy::unused_self, clippy::unnecessary_wraps)]
pub(crate) fn set_permission(
&self,
_item: impl AsRef<Path>,
_item: impl AsRef<UnixPath>,
_node: &Node,
) -> LocalDestinationResult<()> {
Ok(())
Expand Down
6 changes: 0 additions & 6 deletions crates/core/src/backend/node.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use std::{borrow::Cow, cmp::Ordering, fmt::Debug};

#[cfg(not(windows))]
use std::fmt::Write;
#[cfg(not(windows))]
use std::num::ParseIntError;
Expand All @@ -23,15 +22,13 @@ use crate::blob::{tree::TreeId, DataId};
#[non_exhaustive]
pub enum NodeErrorKind<'a> {
/// Unexpected EOF while parsing filename: `{file_name}`
#[cfg(not(windows))]
UnexpectedEOF {
/// The filename
file_name: String,
/// The remaining chars
chars: std::str::Chars<'a>,
},
/// Invalid unicode
#[cfg(not(windows))]
InvalidUnicode {
/// The filename
file_name: String,
Expand All @@ -41,15 +38,13 @@ pub enum NodeErrorKind<'a> {
chars: std::str::Chars<'a>,
},
/// Unrecognized Escape while parsing filename: `{file_name}`
#[cfg(not(windows))]
UnrecognizedEscape {
/// The filename
file_name: String,
/// The remaining chars
chars: std::str::Chars<'a>,
},
/// Parsing hex chars {chars:?} failed for `{hex}` in filename: `{file_name}` : `{source}`
#[cfg(not(windows))]
ParsingHexFailed {
/// The filename
file_name: String,
Expand All @@ -61,7 +56,6 @@ pub enum NodeErrorKind<'a> {
source: ParseIntError,

Check failure on line 56 in crates/core/src/backend/node.rs

View workflow job for this annotation

GitHub Actions / Cross checking x86_64-pc-windows-msvc on stable

cannot find type `ParseIntError` in this scope

Check failure on line 56 in crates/core/src/backend/node.rs

View workflow job for this annotation

GitHub Actions / Cross checking x86_64-pc-windows-gnu on stable

cannot find type `ParseIntError` in this scope
},
/// Parsing unicode chars {chars:?} failed for `{target}` in filename: `{file_name}` : `{source}`
#[cfg(not(windows))]
ParsingUnicodeFailed {
/// The filename
file_name: String,
Expand Down

0 comments on commit e13b75a

Please sign in to comment.