Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chunker): Don't underflow with wrong size_hint #378

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix(chunker): Don't underflow with wrong size_hint #378

merged 2 commits into from
Dec 6, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Dec 2, 2024

see #377

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.2%. Comparing base (667e9fb) to head (211573e).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/chunker.rs 51.7% <100.0%> (+0.5%) ⬆️

... and 27 files with indirect coverage changes

@nardoor nardoor mentioned this pull request Dec 2, 2024
Open
nardoor
nardoor approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@nardoor nardoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

crates/core/src/chunker.rs Show resolved Hide resolved
crates/core/src/chunker.rs Show resolved Hide resolved
@aawsome aawsome enabled auto-merge December 6, 2024 08:37
@aawsome aawsome added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit ae3c55d Dec 6, 2024
27 checks passed
@aawsome aawsome deleted the fix-chunker branch December 6, 2024 09:01
@rustic-release-plz rustic-release-plz bot mentioned this pull request Dec 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
@rustic-release-plz
chore(rustic_core): release v0.7.3 (#380)
6a50c12 
## 🤖 New release
* `rustic_core`: 0.7.2 -> 0.7.3 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`
<blockquote>

##
[0.7.3](rustic_core-v0.7.2...rustic_core-v0.7.3)
- 2024-12-06

### Fixed

- *(chunker)* Don't underflow with wrong size_hint
([#378](#378))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nardoor nardoor nardoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aawsome @nardoor