Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements, Docs and Tests. #16

Open
UsairimIsani opened this issue Sep 17, 2020 · 0 comments
Open

Enhancements, Docs and Tests. #16

UsairimIsani opened this issue Sep 17, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@UsairimIsani
Copy link
Contributor

Sounds great, here are some suggestions:

tests

  • Unit tests for utils.rs, profile.rs, macros::fjp_version, location.rs
  • Integration tests (possible crates: assert-cmd & assert-fs) e.g. works fjp disable firefox, ...

new subcommands

  • trash, mv, cp (see TODO.md)
  • Implementing other subcommands in TODO.md which handle profile content should wait until profile_stream.rs is stable (actually it is experimental).

fine tuning

  • As you know 😉 the new profile sys.
  • See edit and generate-standalone in TODO.md

docs

misc

  • Improvements bash/zsh completions.
  • Scripts to build fjp.deb/fjp.pkg.tar.xz packages (platform/{arch,debian}).

Originally posted by @rusty-snake in #14 (comment)

@rusty-snake rusty-snake added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants