Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): do not run ci on pushes to main or dev #2027

Closed
wants to merge 4 commits into from
Closed

chore(ci): do not run ci on pushes to main or dev #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1715d8
chore(ci): do not run ci on pushes to main or dev
drazisil Aug 20, 2024
a8e198f
chore(security): have code scanning run on every pr
drazisil Aug 20, 2024
f5afad9
Update node.yml
drazisil Aug 21, 2024
e255a35
Merge remote-tracking branch 'origin/dev' into drazisil-patch-1
drazisil Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
name: "CodeQL"

on:
push:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out 'push' events on line 9 and 10 suggests that the workflow will not run on push events. Ensuring regular code scans are run can be important for maintaining code quality; you may want to reconsider this change.

branches: [main]
# push:
drazisil marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling CodeQL analysis on push to main might be a risk. This would mean no static code analysis would be performed to identify vulnerabilities when code is pushed onto the main branch.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out lining 11 and 12 results in all branches triggering a workflow run when a pull request is made. Depending on your project's branch strategy this may be excessive and cause unnecessary use of action minutes.

# branches: [main]
drazisil marked this conversation as resolved.
Show resolved Hide resolved
pull_request:
# The branches below must be a subset of the branches above
branches: [main]
# branches: [main]
drazisil marked this conversation as resolved.
Show resolved Hide resolved
drazisil marked this conversation as resolved.
Show resolved Hide resolved
schedule:
- cron: "36 16 * * 4"

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ name: Node.js

on:
push:
branches:
drazisil marked this conversation as resolved.
Show resolved Hide resolved
drazisil marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping push event actions on 'main' branch could lead to untested code getting into 'main', which is generally considered as production-ready or release branch. We should ensure all tests and actions are still performed on push to these 'main' branch to prevent any issues with the production code.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 28, the 'branches' trigger is set to exclude 'main' and 'dev'. The reason should be clarified and relevant documentation updated accordingly.

- '!main'
drazisil marked this conversation as resolved.
Show resolved Hide resolved
drazisil marked this conversation as resolved.
Show resolved Hide resolved
- '!dev'
drazisil marked this conversation as resolved.
Show resolved Hide resolved
drazisil marked this conversation as resolved.
Show resolved Hide resolved
pull_request:
drazisil marked this conversation as resolved.
Show resolved Hide resolved
drazisil marked this conversation as resolved.
Show resolved Hide resolved
workflow_dispatch:
drazisil marked this conversation as resolved.
Show resolved Hide resolved
merge_group:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'merge_group:' key does not exist in GitHub action workflows. Carefully review the workflow yaml configurations for valid syntax.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 33, 'merge_group' is not a known event type in GitHub Actions. Please correct this to a valid trigger event type.


env:
MCO_LOG_LEVEL: warn
Expand Down
Loading