refactor: ♻️ saving

[drazisil]

for real. this is such a mess that I want to save it while it still works

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced login functionality with improved message handling and response structure.
  • Added a port property to the ConnectedSocket type for better socket management.
  • Introduced a peek method to read data without altering the buffer.
  • New error handling mechanism for socket connections.

• Bug Fixes

  • Updated event handling for socket data to ensure accurate event emissions.

• Tests

  • Modified tests to accommodate new parameters and event names for ConnectedSocket and login functionalities.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces substantial updates to the login functionality, primarily in the packages/transactions/src/login.ts file, where message handling and packet serialization logic have been revamped. Key changes include the introduction of new packet types, such as LoginPayload and LoginCompletePayload, and modifications to the handling of incoming and outgoing packets. Additionally, the ConnectedSocket type in src/socket/ConnectedSocket.ts has been enhanced with new properties and methods, while the socket management logic in src/socket/index.ts has been updated to improve error handling and event processing.

Changes

File	Change Summary
packages/transactions/src/login.ts	Updated imports, replaced TLoginMessage with LoginPayload, modified packet normalization and response creation with new properties.
packages/transactions/test/login.test.ts	Adjusted test setup to set _header.sequence for incomingMessage.
src/socket/ConnectedSocket.ts	Added port property, modified event listeners from data to inData and outData, added peek method.
src/socket/index.ts	Updated newSocket function to include local port, changed event listener to outData, added socketErrorHandler function for error management.
src/socket/ConnectedSocket.test.ts	Updated instantiation of ConnectedSocket_ to require port, changed event name in tests from data to outData.

Possibly related PRs

• refactor: 🎨 migrate to socket module #2180: The changes in this PR involve modifications to socket management, particularly in how the newSocket function is implemented, which is relevant to the changes in the login function's handling of packets and socket interactions.

Suggested labels

size/L

🐰 In the code, we hop and play,
New packets and ports lead the way!
With logs that sparkle, bright and new,
Our features grow, like morning dew.
So let’s rejoice, with code so neat,
A rabbit's dance, on nimble feet! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[deepsource-io]

Here's the code health analysis summary for commits 16757e1..e094be6. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	❌ Failure	❗ 208 occurences introduced 🎯 56 occurences resolved	View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[codecov]

Codecov Report

Attention: Patch coverage is 28.37302% with 722 lines in your changes missing coverage. Please review.

Project coverage is 26.23%. Comparing base (16757e1) to head (e094be6).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ackages/shared-packets/src/LoginCompletePayload.ts	0.00%	122 Missing ⚠️
packages/gateway/src/index.ts	0.00%	78 Missing ⚠️
packages/login/src/login.ts	5.12%	74 Missing ⚠️
packages/shared-packets/src/SqlTimeStamp.ts	0.00%	60 Missing ⚠️
packages/transactions/src/_buyCarFromDealer.ts	12.06%	51 Missing ⚠️
packages/shared-packets/src/LoginPayload.ts	0.00%	48 Missing ⚠️
packages/transactions/src/internal.ts	2.12%	46 Missing ⚠️
...ackages/shared-packets/src/MCOTSServerListEntry.ts	0.00%	44 Missing ⚠️
packages/login/src/handleLoginData.ts	0.00%	39 Missing ⚠️
packages/shared/index.ts	0.00%	38 Missing ⚠️
... and 21 more

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2197      +/-   ##
==========================================
- Coverage   26.55%   26.23%   -0.33%     
==========================================
  Files         220      230      +10     
  Lines       11459    11691     +232     
  Branches      385      436      +51     
==========================================
+ Hits         3043     3067      +24     
- Misses       8416     8624     +208     

Flag	Coverage Δ
cli	59.32% <ø> (ø)
connection	?
database	23.71% <ø> (ø)
gateway	9.48% <0.00%> (-0.39%)	⬇️
lobby	6.75% <100.00%> (+0.53%)	⬆️
login	5.89% <5.51%> (-0.08%)	⬇️
mcots	9.00% <0.00%> (+0.43%)	⬆️
nps	5.76% <ø> (ø)
patch	71.42% <ø> (ø)
persona	16.89% <40.00%> (+0.81%)	⬆️
sessions	85.71% <ø> (ø)
shard	43.31% <ø> (ø)
shared	13.99% <3.77%> (-0.36%)	⬇️
shared-packets	52.32% <34.21%> (-43.17%)	⬇️
transactions	57.95% <41.11%> (-2.79%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/jsdoc@4.0.3	Transitive: environment, eval, filesystem, unsafe	+23	10.6 MB	hegemonic
npm/lint-staged@15.2.10	Transitive: environment, filesystem, shell	+25	1.14 MB	okonet

View full report↗︎

[sonarcloud]

Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud