Handle multiple operations in a same transform string #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyoz
approved these changes
Mar 5, 2024
bug: x+tuples[j*3][0] mixed transformed x and untransformed tuples[j*3][0], effecitvely making x transformed (e.g., scale by -1) twice. This calls for similar fix in parseCurveToRel().
|
Hi, Russell,
Thanks for approving the pull request.
FYI. I just force-pushed my master, which limits the fix of commit titled ‘path: fix applying transform multiple times …’ to only the function parseCurveToRelDI(). The parallel function parseCurveToRel() calls for its own commit of a similar fix, since it’s more complex and intertwined with interpolating Bezier curve.
Best,
Fangzhe
From: Russell Oliver ***@***.***>
Date: Tuesday, March 5, 2024 at 7:04 AM
To: rustyoz/svg ***@***.***>
Cc: Fangzhe Chang (Nokia) ***@***.***>, Author ***@***.***>
Subject: Re: [rustyoz/svg] Handle multiple operations in a same transform string (PR #15)
@rustyoz approved this pull request.
—
Reply to this email directly, view it on GitHub<#15 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEUJORZZQGRBGOHKCDZ3453YWWYGNAVCNFSM6AAAAABDVKXGBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJWGY4TMMRYHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the parseTransform function to allow transform string to contain a list of transform definitions, and also added a unit test. Please review and merge. Thanks.