Signature failing during the funding_sign with core lightning

[vincenzopalazzo]

While running the current code on the latest core lightning while I am trying to simplify it a little bit but I am starting to realize that it is a complete mess and we should rewrite it from scratch.

However, back to the issue. When lnprototest init a v1 funding channel there is a funding signature check failure.

If I remove the assertion inside the test https://github.com/rustyrussell/lnprototest/blob/master/tests/test_bolt2-01-open_channel.py#L265 the test tests/test_bolt2-01-open_channel.py::test_open_channel_opener_side will pass, otherwise will fail with the following error

2024-11-11T17:26:42.013Z DEBUG   hsmd: Shutting down

ERROR    root:utils.py:98 Traceback (most recent call last):
  File "/home/vincent/github/work/lnprototest/lnprototest/utils/utils.py", line 95, in run_runner
    runner.run(test)
  File "/home/vincent/github/work/lnprototest/lnprototest/runner.py", line 100, in run
    all_done = sequence.action(self)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/vincent/github/work/lnprototest/lnprototest/structure.py", line 55, in action
    all_done &= e.action(runner)
                ^^^^^^^^^^^^^^^^
  File "/home/vincent/github/work/lnprototest/lnprototest/event.py", line 602, in action
    raise EventError(self, "{} != {}".format(a, b))
lnprototest.errors.EventError: `20b36f9b3fb0577d078b13021e49c7b93d124bf3eb7c8f75d7decf6bdcd2c9475a76a118e1b8f44ce32eca7abee2704f463c54df223cccaa35a8624c3a4819b6 != Sig(0000000000000000000000000000000000000000000000000000000000000010,e6e1cf9c861f1b4c245652ff281a4f052427aa1342e3299e23d262390e73101c)` on event [{"event": "CheckEq", "file": "test_bolt2-01-open_channel.py", "pos": "265"},]
======================================================================================================================= short test summary info ========================================================================================================================
FAILED tests/test_bolt2-01-open_channel.py::test_open_channel_opener_side - AssertionError: `20b36f9b3fb0577d078b13021e49c7b93d124bf3eb7c8f75d7decf6bdcd2c9475a76a118e1b8f44ce32eca7abee2704f463c54df223cccaa35a8624c3a4819b6 != Sig(0000000000000000000000000000000000000000000000000000000000000010,e6e1cf9c861f1b4c245652ff281a4f052427aa134...

the type Sig is really black magic for me now and git blame point to @rustyrussell

@rustyrussell Du you have any clue on what can cause this regression? it is possible that a code change inside core lightning?

@Psycho-Pirate Do you see this problem in LDK sample?