Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure when closing with a wrong pub key #76

Open
vincenzopalazzo opened this issue Mar 1, 2023 · 0 comments
Open

test failure when closing with a wrong pub key #76

vincenzopalazzo opened this issue Mar 1, 2023 · 0 comments
Labels
🐛 bug 🐛 Something isn't working 🔨 to be reproduced 🔨 Required to be reproduced in the test env SPEC: BOLT 2 - Close Channel Related to BOLT 2, with more focus to the close channel side

Comments

@vincenzopalazzo
Copy link
Collaborator

When we was going to close the channel with the wrong pub key, sometime we receive a spec violation from the tests

This are some logs


ERROR    root:helpers.py:170 Traceback (most recent call last):
  File "/work/lnprototest/tests/helpers.py", line 167, in run_runner
    runner.run(test)
  File "/work/lnprototest/lnprototest/runner.py", line 99, in run
    all_done = sequence.action(self)
  File "/work/lnprototest/lnprototest/structure.py", line 55, in action
    all_done &= e.action(runner)
  File "/work/lnprototest/lnprototest/event.py", line 342, in action
    raise EventError(
lnprototest.errors.EventError: `Got msg banned by {"event": "MustNotMsg", "file": "test_bolt2-01-close_channel.py", "pos": "156"}: 0026a37362839b13f61cfe82d35bd397b1264c389b245847cfb6111b38892546dc7700160014d640ab16f347d1de5aba5a715321a5fc4ba9a5d5` on event [{"event": "ExpectMsg", "file": "test_bolt2-01-close_channel.py", "pos": "157"},]
=========================== short test summary info ============================
FAILED tests/test_bolt2-01-close_channel.py::test_close_channel_shutdown_msg_wrong_script_pubkey_receiver_side
================== 1 failed, 26 passed, 18 skipped in 50.88s ===================
make: *** [Makefile:14: check] Error 1

But core lightning log the correct message

2023-03-01T18:22:45.786Z DEBUG   lightningd: io_loop_with_timers: main
2023-03-01T18:22:45.787Z INFO    02f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9-chan#1: Peer transient failure in CHANNELD_NORMAL: Bad shutdown scriptpubkey 2102653a63d591390de0ff80830c1ec8c83b89a556d1e8e172c0181ff7ff807eae6eac
2023-03-01T18:22:45.787Z DEBUG   02f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9-channeld-chan#1: Status closed, but not exited. Killing
2023-03-01T18:22:45.787Z DEBUG   0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798-hsmd: Got WIRE_HSMD_CUPDATE_SIG_REQ
2023-03-01T18:22:45.787Z DEBUG   connectd: REPLY WIRE_CONNECTD_START_SHUTDOWN_REPLY with 0 fds
@vincenzopalazzo vincenzopalazzo added 🐛 bug 🐛 Something isn't working 🔨 to be reproduced 🔨 Required to be reproduced in the test env SPEC: BOLT 2 - Close Channel Related to BOLT 2, with more focus to the close channel side labels Mar 1, 2023
@vincenzopalazzo vincenzopalazzo changed the title test failure when closing with a wring pub key test failure when closing with a wrong pub key Mar 12, 2023
@vincenzopalazzo vincenzopalazzo added this to the lnprototest 0.0.1 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug 🐛 Something isn't working 🔨 to be reproduced 🔨 Required to be reproduced in the test env SPEC: BOLT 2 - Close Channel Related to BOLT 2, with more focus to the close channel side
Projects
None yet
Development

No branches or pull requests

1 participant