Fix/smooth animation #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyb99
force-pushed
the
fix/smooth_animation
branch
from
8fc4780
to
a71936d
Compare
mohammad-fxbytes
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Animation (Bounce Out):
Here, as you can see, the bounce comes in with a delay, which seems a bit jittery or off.
Decelerate
Here, it pops out, but does not bounce, so it seems smoother than before.
I have also reduced the duration of the animation to reduce the apparent time delay between actual drag start and the drag behaviour of the animation.
FastOutSlowIn:
This is also similar to Decelerate but a bit less like it. Personally, I would prefer decelerate over this any day, but its upto you to choose.
I looked up the actual design and found out that Decelerate would come closest to it.
closes: #16