Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN-1612: Deps, tests, promises #1

Merged
merged 6 commits into from
Dec 2, 2024
Merged

RUN-1612: Deps, tests, promises #1

merged 6 commits into from
Dec 2, 2024

Conversation

MinaKemp
Copy link
Collaborator

@MinaKemp MinaKemp commented Dec 2, 2024 •
edited
Loading

  • Set minimum node version to 18
  • Update/remove deps to fix vulnerabilities (currently 0!)
  • Update npm scripts
    • Add easy test commands
    • Transpile tests on-demand so that they can be written against source code instead of dist code
  • Conditionally remove Promise shim (HYPERNOVA_PROMISE_SHIMS env var)
    • Also conditionally log performance metrics around this (HYPERNOVA_PROFILING env var)
  • Add/update tests
    • Add escape hatch to shut servers off so they don't persist after their test is done

@MinaKemp
Deps, tests, promises
090bc75 
- Set minimum node version to 16
- Update/remove deps to fix vulnerabilities (currently 0!)
- Update npm scripts
  - Add easy test commands
  - Transpile tests on-demand so that they can be written against
    source code instead of dist code
- Conditionally remove Promise shim (HYPERNOVA_PROMISE_SHIMS env var)
  - Also conditionally log performance metrics around this
    (HYPERNOVA_PROFILING env var)
- Add/update tests
  - Add escape hatch to shut servers off so they don't persist after
    their test is done
@MinaKemp
Use simple test workflow
40a49a2
@MinaKemp
Lint after npm install
ff230a4
@MinaKemp
Node version should be 18
a9b1741
@MinaKemp
v4 on github actions
b471794
@MinaKemp
Only run on push
fb6d955
@MinaKemp MinaKemp requested a review from a team December 2, 2024 14:27
@MinaKemp MinaKemp changed the title Deps, tests, promises RUN-1612: Deps, tests, promises Dec 2, 2024
ceautery
ceautery approved these changes Dec 2, 2024
View reviewed changes
Copy link

@ceautery ceautery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of TIL's in here. I had to go hit MDN and figure out some obscure Promise methods I've never used before 😂

Looking forward to working with this down the road.

@MinaKemp MinaKemp merged commit 9a35248 into main Dec 2, 2024
2 of 3 checks passed
@MinaKemp MinaKemp deleted the develop/deps-tests-promises branch December 2, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceautery ceautery ceautery approved these changes

@sjoconnor sjoconnor sjoconnor approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinaKemp @sjoconnor @ceautery