New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwythonStreamer on_error in examples and documentation is wrong #538

Open

EhsanKia opened this issue Aug 19, 2020 · 0 comments

EhsanKia commented Aug 19, 2020

This pull request added headers to the on_error call:
#504

The issue is that all other the examples and documentation show on_error as taking two parameters, so they are all broken.
I copied the code from here:
https://twython.readthedocs.io/en/latest/usage/streaming_api.html

Looking at the codebase, here are the places that need to be updated:
https://github.com/ryanmcgrath/twython/blob/master/docs/usage/streaming_api.rst
https://github.com/ryanmcgrath/twython/blob/master/examples/stream.py
https://github.com/ryanmcgrath/twython/blob/master/tests/test_streaming.py

I can try submitting a PR requests, though updating those seems fairly trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment