Add support for Active Record 5.2

[rzane]

🎉 This has been much easier than I had expected!

There are only two remaining issues:

• Polymorphic associations
• BabySqueel::Association#! spec is broken

Fixes #85.

[coveralls]

Coverage increased (+0.005%) to 98.981% when pulling 34e07ba on 52-support into b165a50 on master.

[rzane]

Okay, seems like this all comes down to activerecord-hackery/polyamorous#37.

[rainerborene]

@rzane master branch is already usable? i can't use it yet.

gem "join_dependency", github: "rzane/join_dependency"
gem "baby_squeel", github: "rzane/baby_squeel"

ArgumentError: wrong number of arguments (given 3, expected 2)
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/baby_squeel-924cfe4b0373/lib/baby_squeel/active_record/query_methods.rb:43:in `build_joins'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation/query_methods.rb:928:in `build_arel'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation/query_methods.rb:903:in `arel'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation.rb:554:in `block in exec_queries'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation.rb:578:in `skip_query_cache_if_necessary'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation.rb:542:in `exec_queries'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation.rb:414:in `load'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation.rb:200:in `records'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation/finder_methods.rb:502:in `find_take'
  /home/rainer/.asdf/installs/ruby/2.4.3/lib/ruby/gems/2.4.0/gems/activerecord-5.2.0/lib/active_record/relation/finder_methods.rb:103:in `take'
  /home/rainer/Projects/rails/app/models/user/custom_devise.rb:33:in `find_for_authentication'

[rzane]

@rainerborene, I think you forgot to specify the branch. It should be:

gem "join_dependency", github: "rzane/join_dependency"
gem "baby_squeel", github: "rzane/baby_squeel", branch: "52-support"

However, this PR hasn't been merged yet for a good reason. Polymorphic associations are broken upstream (in the polyamorous gem), as documented in this issue: activerecord-hackery/polyamorous#37. So, if you query a polymorphic association, the wrong record might be returned.

[Schwad]

Okay, I am also pointing to this branch. @rzane, feel free to @ message me when it's ready, or if there's anything else I can do to help!!!

[Schwad]

Also @rzane just going to say that I tried to point to your branch but it broke because of the sqlite3 dependency on join_dependency.... This may be very dangerous but I am forking it to see how things run without that dependency.... 🙊

[rzane]

Oh whoops, that was an accident. Sqlite is definitely not a real dependency. I'll fix that today.

[rzane]

Okay, I'm going to merge this. The remaining issue (re: polymorphic associations) is not a Baby Squeel issue, and therefore, it doesn't make sense not to release this.

For reference, this is the bug: activerecord-hackery/polyamorous#37.

@Schwad, that sqlite dependency issue should be resolve now as well.

To anyone who uses Baby Squeel or Ransack and uses polymorphic associations, I wouldn't recommend upgrading to 5.2 until that issue is resolved.

[rzane]

Released: https://rubygems.org/gems/baby_squeel/versions/1.2.1

[Schwad]

@rzane Awesome!!! Thank you so much!!!

[ConnerMan]

Much appreciated @rzane! 👍