bugfix/separate-observer-parsing

s7techlab · Oct 11, 2023 · 21104b3 · 21104b3
1 parent bf7b36d
commit 21104b3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/observer/block_peer_common.go b/observer/block_peer_common.go
@@ -186,6 +186,8 @@ func (bp *BlockPeer) initChannels(ctx context.Context) {
 func (bp *BlockPeer) peerChannel(ctx context.Context, channel string) *blockPeerChannel {
 	seekFrom := bp.seekFrom[channel]
 	if seekFrom > 0 {
+		// it must be -1, because start position here is excluded from array
+		// https://github.com/s7techlab/hlf-sdk-go/blob/master/proto/seek.go#L15
 		seekFrom--
 	}
 

diff --git a/observer/block_peer_common_concurrently.go b/observer/block_peer_common_concurrently.go
@@ -66,6 +66,8 @@ func (bp *BlockPeer) initChannelsConcurrently(ctx context.Context, blocksByChann
 func (bp *BlockPeer) peerChannelConcurrently(ctx context.Context, channel string, blocksByChannels *BlocksByChannels) *blockPeerChannel {
 	seekFrom := bp.seekFrom[channel]
 	if seekFrom > 0 {
+		// it must be -1, because start position here is excluded from array
+		// https://github.com/s7techlab/hlf-sdk-go/blob/master/proto/seek.go#L15
 		seekFrom--
 	}
 

diff --git a/observer/block_peer_parsed.go b/observer/block_peer_parsed.go
@@ -149,6 +149,8 @@ func (pbp *ParsedBlockPeer) initParsedChannels(ctx context.Context) {
 func (pbp *ParsedBlockPeer) peerParsedChannel(ctx context.Context, channel string) *parsedBlockPeerChannel {
 	seekFrom := pbp.blockPeer.seekFrom[channel]
 	if seekFrom > 0 {
+		// it must be -1, because start position here is excluded from array
+		// https://github.com/s7techlab/hlf-sdk-go/blob/master/proto/seek.go#L15
 		seekFrom--
 	}
 

diff --git a/observer/block_peer_parsed_concurrently.go b/observer/block_peer_parsed_concurrently.go
@@ -68,6 +68,8 @@ func (pbp *ParsedBlockPeer) initParsedChannelsConcurrently(ctx context.Context,
 func (pbp *ParsedBlockPeer) peerParsedChannelConcurrently(ctx context.Context, channel string, blocksByChannels *ParsedBlocksByChannels) *parsedBlockPeerChannel {
 	seekFrom := pbp.blockPeer.seekFrom[channel]
 	if seekFrom > 0 {
+		// it must be -1, because start position here is excluded from array
+		// https://github.com/s7techlab/hlf-sdk-go/blob/master/proto/seek.go#L15
 		seekFrom--
 	}