Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately transfer tokens when the vesting period has ended #37

Open
PaulRBerg opened this issue Jan 5, 2025 · 4 comments
Open

Immediately transfer tokens when the vesting period has ended #37

PaulRBerg opened this issue Jan 5, 2025 · 4 comments
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

When end time > block timestamp, transfer the airdrop amount directly to the user, without creating a stream.

cc @sablier-labs/frontend, this may have implications for the informatinal tooltips in the UI

Discussed in #33

Originally posted by PaulRBerg December 23, 2024

@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Jan 5, 2025
@razgraf
Copy link
Member

razgraf commented Jan 6, 2025

It will have implications to indexers and app logic too. This makes campaign actions into a mixture of Instant and Airstreams actions, since the Claim event can now yield either a simple transaction (the transfer, post condition) or a streamId (pre condition). Won't be a problem, just something to have in mind.

@PaulRBerg
Copy link
Member Author

Right. Would it help if we emitted different events?

@razgraf
Copy link
Member

razgraf commented Jan 6, 2025

Event will be required for sure! But we could simply emit a Claim event with streamId set to 0 if we don't want to refactor too much. That'll help mark it as a direct transfer instead of a stream claim.

@PaulRBerg
Copy link
Member Author

emit a Claim event with streamId set to 0 if

Yeah, that should work well. I wonder if a boolean flag would be helpful, though? That would be slightly clearer

@smol-ninja smol-ninja removed this from Lockup 2.1.0 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

No branches or pull requests

4 participants