feat: include shape in merkle contracts #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
changed the title
Co-authored-by: Paul Razvan Berg <prberg@proton.me>
refactor: rename var to campaignName refactor: store the campaign name as string test: update tests accordingly
|
pushed a commit to address the feedback, lmk if it looks good @smol-ninja |
|
Yes. Thanks for the commit. Looks good to me. Can you please approve the PR if there are no more suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1.
Changelog:
saltby encodingbaseParamsinstead encoding parameters separately. This helps to prevent "stack too deep error" caused after addingshapeinkeccak256(abi.encodePacked(..))of salt.assettotokenas a result of Refactor asset to token v2-core#1097.shapeof typestring. Instead of reverting on longer than 32 chars length, it truncates the name to 32 chars.NAMEtoCAMPAIGN_NAMEinDefaultscontract.@andreivladbrg the idea of storing shape as
bytes32did not work because when the string of length less than 32 characters is stored asbytes32, it adds0to make it fit into 32 bytes slot which changes the length of the string upon conversion back to string. On the other hand, storing it as a string datatype preserves the string length as well in the storage. Therefore I decided to store it as a string and truncates its length if the length exceeds 32 characters.