feat: shape name in create lockup #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
force-pushed
the
feat/emit-shape-name
branch
from
c121ee9 to
ae77c12
Compare
andreivladbrg
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Great work, left some comments below:
I did not fuzz shape names in Fork and Invariant tests since its only emitted in event. So, concrete tests and fuzz tests are sufficient imo
agree that we don't need to fuzz this in fork/invariants (it would be superfluous)
test/integration/concrete/lockup-base/create-with-timestamps/createWithTimestamps.t.sol
Outdated
Show resolved
Hide resolved
docs: uses assertive comments in natspecs test: makes default shape name with non-zero length Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
|
Thanks for the review @andreivladbrg. I have incorporated all your suggestions except one. Let me know what you think about that. |
PaulRBerg
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Unfortunately, 32 bytes is not enough to prevent HTML injection. From ChatGPT convo:
<img src=x onerror=alert(1)>I think we just have to accept the potential risk and sanitize the shape string at the UI level, cc @sablier-labs/frontend.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1086.
Changelog
shapeand notshapeNameas I suppose the "name" keyword is implicit given that its astringtype