Refactor asset to token #1097
Merged
Refactor asset to token #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
requested changes
Nov 26, 2024
tests/integration/concrete/nft-descriptor/safe-asset-decimals/safeAssetDecimals.t.sol
Outdated
Show resolved
Hide resolved
smol-ninja
reviewed
Nov 26, 2024
smol-ninja
reviewed
Nov 26, 2024
Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
smol-ninja
approved these changes
Nov 26, 2024
|
@smol-ninja just pushed a commit to address the feedback, lmk if it looks good, and if yes, could you approve it? |
|
You have an approval with Haka. |
loool, what is this 😂😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #991
Notes: in order to keep the backwards compatibility with previous versions of the lockup contracts in
LockupNFTDescriptorI had to include the logic for thegetAssetin theLockupNFTDescriptor.tokenURIfunction.