Install dependencies with Node.js instead of git modules #734
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I've made sure to mention that the recommended method to install 
However, I realized that for integrators who still use |
build: remove .gitmodules build: remove lib dir build: include test/utils in files published docs: specify recommended installation method on README chore: update remappings accordingly ci: install deps with pnpm install and remove "recursive"
andreivladbrg
force-pushed
the
build/modules-to-npm
branch
from
366c333 to
d3fcba0
Compare
Those types have always been problematic, actually. See this. So it's good that we are getting rid of them.
Yes, we should. Also, please test that it works properly! |
Great
I did. You can test it yourself using this branch from periphery. Everything works there. |
andreivladbrg
force-pushed
the
build/modules-to-npm
branch
from
4fe129e to
ec8378d
Compare
ci: restore the node modules in coverage job
andreivladbrg
force-pushed
the
build/modules-to-npm
branch
from
ec8378d to
2a8b0b4
Compare
| - name: "Install the Node.js dependencies" | ||
| run: "pnpm install" |
There was a problem hiding this comment.
This step is now redundant given that we are caching node_modules.
There was a problem hiding this comment.
the slither-analyze job is going to be removed from ci.yml and we will need the pnpm installin its own file, see #726
There was a problem hiding this comment.
Fine. In this case, it doesn't really matter what we do here - can you keep my latest commit as is, please?
Fantastic |
chore: fix formatting in CI files chore: improve wording in CI files ci: remove redundant "pnpm install" steps
PaulRBerg
force-pushed
the
build/modules-to-npm
branch
from
be86351 to
a110f20
Compare
* build: install deps only with Node.js build: remove .gitmodules build: remove lib dir build: include test/utils in files published docs: specify recommended installation method on README chore: update remappings accordingly ci: install deps with pnpm install and remove "recursive" * feat: remove re-exported types * style: add line * ci: install pnpm and Node.js on each job * chore: update Slither config * test: update Precompiles bytecode * build: include remappings.txt file in the package * ci: cache the node modules and re use them * docs: improve README * build: remove unnecessary remmapings file from package * ci: rename cached key ci: restore the node modules in coverage job * ci: consistent caching keys chore: fix formatting in CI files chore: improve wording in CI files ci: remove redundant "pnpm install" steps * build: set peer dep version to "4.0.x" --------- Co-authored-by: Paul Razvan Berg <paul.razvan.berg@gmail.com>
docs: update date in changelog
Addresses #508 and updates
prb-mathto4.0.2.Since this project is not going to have a
libdirectory anymore, it no longer makes sense to keep the re-exported types. This is because if the project is installed withforge install sablier-labs/v2-coreit won't have recursive modules to install, and node modules can't be installed. And if the project is installed withyarn add @sablier/v2-core, it would automatically install those deps (prb-math and openzeppelin).