Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proxy targets #226

Merged
merged 4 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 32 additions & 155 deletions .gas-snapshot

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .github/workflows/create-merkle-streamer-ll.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
API_KEY_SNOWTRACE: ${{ secrets.API_KEY_SNOWTRACE }}
FOUNDRY_PROFILE: "optimized"
MNEMONIC: ${{ secrets.MNEMONIC }}
RPC_URL_GOERLI: ${{ secrets.RPC_URL_GOERLI }}
RPC_URL_SEPOLIA: ${{ secrets.RPC_URL_SEPOLIA }}
RPC_URL_MAINNET: ${{ secrets.RPC_URL_MAINNET }}

on:
Expand All @@ -21,7 +21,7 @@ on:
description: "Parameters needed for the script, as comma-separated tupples."
required: true
chain:
default: "goerli"
default: "sepolia"
description: "Chain name as defined in the Foundry config."
required: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-batch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ env:
API_KEY_SNOWTRACE: ${{ secrets.API_KEY_SNOWTRACE }}
FOUNDRY_PROFILE: "optimized"
MNEMONIC: ${{ secrets.MNEMONIC }}
RPC_URL_GOERLI: ${{ secrets.RPC_URL_GOERLI }}
RPC_URL_MAINNET: ${{ secrets.RPC_URL_MAINNET }}
RPC_URL_SEPOLIA: ${{ secrets.RPC_URL_SEPOLIA }}

on:
workflow_dispatch:
inputs:
chain:
default: "goerli"
default: "sepolia"
description: "Chain name as defined in the Foundry config."
required: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-merkle-streamer-factory.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ env:
API_KEY_SNOWTRACE: ${{ secrets.API_KEY_SNOWTRACE }}
FOUNDRY_PROFILE: "optimized"
MNEMONIC: ${{ secrets.MNEMONIC }}
RPC_URL_GOERLI: ${{ secrets.RPC_URL_GOERLI }}
RPC_URL_MAINNET: ${{ secrets.RPC_URL_MAINNET }}
RPC_URL_SEPOLIA: ${{ secrets.RPC_URL_SEPOLIA }}

on:
workflow_dispatch:
inputs:
chain:
default: "goerli"
default: "sepolia"
description: "Chain name as defined in the Foundry config."
required: false

Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/deploy-periphery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,16 @@ env:
API_KEY_SNOWTRACE: ${{ secrets.API_KEY_SNOWTRACE }}
FOUNDRY_PROFILE: "optimized"
MNEMONIC: ${{ secrets.MNEMONIC }}
RPC_URL_GOERLI: ${{ secrets.RPC_URL_GOERLI }}
RPC_URL_MAINNET: ${{ secrets.RPC_URL_MAINNET }}
RPC_URL_SEPOLIA: ${{ secrets.RPC_URL_SEPOLIA }}

on:
workflow_dispatch:
inputs:
chain:
default: "goerli"
default: "sepolia"
description: "Chain name as defined in the Foundry config."
required: false
permit2:
default: "0x000000000022D473030F116dDEE9F6B43aC78BA3"
description: "The address of the Permit2 contract."
required: false


jobs:
Expand All @@ -44,10 +40,9 @@ jobs:
forge script script/DeployPeriphery.s.sol
--broadcast
--rpc-url "${{ inputs.chain }}"
--sig "run(address)"
--sig "run()"
--verify
-vvvv
"${{ inputs.permit2 }}"

- name: "Add workflow summary"
run: |
Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/deploy-protocol.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ env:
FOUNDRY_OPTIMIZER_RUNS: "1000" # needed to compile V2 Core
FOUNDRY_PROFILE: "optimized"
MNEMONIC: ${{ secrets.MNEMONIC }}
RPC_URL_GOERLI: ${{ secrets.RPC_URL_GOERLI }}
RPC_URL_MAINNET: ${{ secrets.RPC_URL_MAINNET }}
RPC_URL_SEPOLIA: ${{ secrets.RPC_URL_SEPOLIA }}

on:
workflow_dispatch:
Expand All @@ -23,17 +23,13 @@ on:
description: "Initial protocol admin."
required: false
chain:
default: "goerli"
default: "sepolia"
description: "Chain name as defined in the Foundry config."
required: false
max-segment-count:
default: "300"
description: "Maximum number of segments allowed in a stream."
required: false
permit2:
default: "0x000000000022D473030F116dDEE9F6B43aC78BA3"
description: "The permit2 address."
required: false

jobs:
deploy-protocol:
Expand All @@ -52,12 +48,11 @@ jobs:
forge script script/DeployProtocol.s.sol
--broadcast
--rpc-url "${{ inputs.chain }}"
--sig "run(address,uint256,address)"
--sig "run(address,uint256)"
--verify
-vvvv
"${{ inputs.admin }}"
"${{ inputs.max-segment-count }}"
"${{ inputs.permit2 }}"

- name: "Add workflow summary"
run: |
Expand Down
49 changes: 0 additions & 49 deletions .github/workflows/deploy-proxy-target-approve.yml

This file was deleted.

54 changes: 0 additions & 54 deletions .github/workflows/deploy-proxy-target-permit2.yml

This file was deleted.

49 changes: 0 additions & 49 deletions .github/workflows/deploy-proxy-target-push.yml

This file was deleted.

8 changes: 0 additions & 8 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
branch = "release-v4.9"
path = "lib/openzeppelin-contracts"
url = "https://github.com/OpenZeppelin/openzeppelin-contracts"
[submodule "lib/permit2"]
branch = "main"
path = "lib/permit2"
url = "https://github.com/uniswap/permit2"
[submodule "lib/prb-proxy"]
branch = "release-v4"
path = "lib/prb-proxy"
url = "https://github.com/PaulRBerg/prb-proxy"
[submodule "lib/prb-test"]
branch = "release-v0"
path = "lib/prb-test"
Expand Down
5 changes: 2 additions & 3 deletions foundry.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
fs_permissions = [{ access = "read", path = "out-optimized" }]
gas_reports = [
"SablierV2MerkleStreamerFactory",
"SablierV2MerkleStreamerLL",
"SablierV2ProxyTarget",
"SablierV2MerkleStreamerLL"
]
libs = ["lib"]
optimizer = true
Expand Down Expand Up @@ -73,4 +72,4 @@
mainnet = "${RPC_URL_MAINNET}"
optimism = "https://optimism-mainnet.infura.io/v3/${API_KEY_INFURA}"
polygon = "https://polygon-mainnet.infura.io/v3/${API_KEY_INFURA}"
sepolia = "https://sepolia.infura.io/v3/${API_KEY_INFURA}"
sepolia = "RPC_URL_SEPOLIA"
PaulRBerg marked this conversation as resolved.
Show resolved Hide resolved
1 change: 0 additions & 1 deletion lib/permit2
Submodule permit2 deleted from cc56ad
1 change: 0 additions & 1 deletion lib/prb-proxy
Submodule prb-proxy deleted from 972afc
5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@
},
"dependencies": {
"@openzeppelin/contracts": "4.9.2",
"@prb/proxy": "4.0.1",
"@sablier/v2-core": "1.0.2",
"@uniswap/permit2": "github:Uniswap/permit2#cc56ad0f3439c502c246fc5cfcc3db92bb8b7219"
"@sablier/v2-core": "1.0.2"
},
"devDependencies": {
"prettier": "^2.8.8",
Expand Down Expand Up @@ -46,7 +44,6 @@
"web3"
],
"peerDependencies": {
"@prb/proxy": "4.0.1",
"@sablier/v2-core": "1.0.2"
},
"publishConfig": {
Expand Down
16 changes: 0 additions & 16 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions remappings.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts/
@prb/proxy/=lib/prb-proxy/
@prb/proxy-test/=lib/prb-proxy/test/
@prb/test/=lib/prb-test/src/
@sablier/v2-core/=lib/v2-core/
@sablier/v2-core-script/=lib/v2-core/script/
@sablier/v2-core-test/=lib/v2-core/test/
@uniswap/permit2/=lib/permit2/src/
@uniswap/permit2-test/=lib/permit2/test/
forge-std/=lib/forge-std/src/
solady/=lib/solady/src/
Loading