Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_expressed_genes - fix for Seurat v5 and add method for matrices #250

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

csangara
Copy link
Member

This slightly differs from #247 in that this is no longer true:

  • The order of arguments has changed from function(ident, seurat_obj, pct = 0.1, assay_oi = NULL) to function(seurat_obj, ident, assay_oi = NULL, pct = 0.1, ...) because the main object has to be the first argument

The S3Method is now written to dispatch on the second argument to maintain consistency with previous versions. Therefore, the function is still defined as function(celltype_oi, seurat_obj, pct = 0.1, assay_oi = NULL, ...), which will still work with the vignettes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (0e14cbe) 70.08% compared to head (17d0efd) 69.59%.
Report is 14 commits behind head on master.

Files Patch % Lines
R/supporting_functions.R 26.19% 62 Missing ⚠️
R/application_prediction.R 32.69% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   70.08%   69.59%   -0.50%     
==========================================
  Files          16       16              
  Lines        5419     5472      +53     
==========================================
+ Hits         3798     3808      +10     
- Misses       1621     1664      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csangara csangara merged commit 88ed083 into master Jan 29, 2024
3 checks passed
@csangara csangara deleted the get-expressed-genes-2 branch January 29, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_expressed_genes function for sparse matrix
2 participants