Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prioritization table and mushroom plot defaults #300

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Conversation

csangara
Copy link
Member

@csangara csangara commented Aug 27, 2024

  • Change p_val_x_adapted to p_val_adapted_x, where x = "ligand" or "receptor". This mostly affects the generate_prioritization_table function. This data frame returned by this function now also has a "prioritization_rank" column that contains the rankings of the LR pairs based on "prioritization_score" (with rank 1 being the highest).

The behavior of make_mushroom_plot function is also changed as follows:

  • Default color is now the "scaled_p_val_adapted" column instead of "scaled_lfc" to better evaluate cell type specificity criteria (as the lfc column wasn't used for prioritization anyway)
  • Sender cell types (x-axis) now follows the order of prioritization_table$sender column if it is a factor
  • size parameter is checked for the correct range (between 0 and 1.001) to prevent overgrown mushrooms
  • Addition of a new parameter called use_absolute_rank (default: FALSE) that will determine whether the absolute rankings are used to filter the table to top_n. If TRUE, this may return an empty table for cell types where LR pairs are all ranked lowly.
  • (Not relevant for users) Added keywords for this column (as p-value was written as "p_val" instead of "pval" unlike the other columns)

@csangara csangara linked an issue Aug 27, 2024 that may be closed by this pull request
@csangara csangara changed the title Change column names of prioritization table and mushroom plot defaults Change prioritization table and mushroom plot defaults Aug 30, 2024
@csangara csangara merged commit fca57c4 into master Sep 5, 2024
4 of 5 checks passed
@csangara csangara deleted the issue-297 branch September 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming convention in prioritization table
1 participant