Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error retrieving boolean annotations #279

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

npalacioescat
Copy link
Member

Fixed an error when processing boolean annotations that caused everything to be False. This was making some methods to give unexpected results e.g. to retrieve no ligand-receptor interactions

For some reason the attribute fields were all uppercase (e.g. "TRUE"), therefore rec[attr] == 'True' was returning False when it was actually True. Now regardless of the case ("True", "TRUE", "true", "TrUe", etc.), returns True

Similar thing applied in the check below for "False".

Fixed an error when processing boolean annotations that caused everything to be False. This was making some methods to give unexpected results e.g. to retrieve no ligand-receptor interactions
@npalacioescat npalacioescat added the fix Solved a bug, error or typo label Feb 15, 2024
@deeenes deeenes merged commit fbff6cd into master Feb 16, 2024
1 check failed
@npalacioescat npalacioescat deleted the Fix-cellphonedb_complex_annotations branch February 16, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Solved a bug, error or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants