Skip to content

Commit

Permalink
Remove some console.logs
Browse files Browse the repository at this point in the history
  • Loading branch information
yagopv committed Sep 28, 2023
1 parent d2bfa4e commit bbfe4c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
6 changes: 1 addition & 5 deletions packages/protocol-kit/src/managers/signatureManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ class SignatureManager {
let dynamicBytes = ''

for (const sig of signatures) {
console.log(sig)
if (sig.isSmartContractSignature) {
/*
A contract signature has a static part of 65 bytes and the dynamic part that needs to be appended
Expand Down Expand Up @@ -190,8 +189,6 @@ class SignatureManager {
}

parseSignature(signatures: any, safeTxHash: string, ignoreTrailing = true): string[] {
console.log(safeTxHash)

if (!signatures) {
return []
}
Expand Down Expand Up @@ -244,11 +241,10 @@ class SignatureManager {
// EOA
safeSignature = 'EOA'
}
console.log(safeSignature)

safeSignatures.push(safeSignature)
}

console.log('Safe Signatures:', safeSignatures)
return safeSignatures
}
}
Expand Down
6 changes: 2 additions & 4 deletions packages/protocol-kit/tests/e2e/eip1271.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,6 @@ describe('EIP1271', () => {
data: messageHash // TODO: Why the messageHash and not the safeMessageHash ?
})

console.log('typedDataSig2: ', typedDataSig)

// Validate the signature sending the Safe message hash and the concatenated signatures
const isValid = await safeSdk1.signatures.isValidSignature(messageHash, [
typedDataSig,
Expand All @@ -213,7 +211,7 @@ describe('EIP1271', () => {

// Hash the message
const messageHash = hashMessage(MESSAGE)
// Get the Safe message hash of the hashed message
// Get the Safe message hash
const safeMessageHash = await safeSdk1.signatures.getMessageHash(messageHash)

// Sign the Safe message with the owners
Expand All @@ -225,7 +223,7 @@ describe('EIP1271', () => {
data: messageHash // TODO: Why the messageHash and not the safeMessageHash ?
})

// Smart contract signature
// Sign with the Smart contract
const signerSafeMessageHash = await safeSdk3.signatures.getMessageHash(messageHash)
const signerSafeSig = await safeSdk3.signatures.signSafeMessageHash(signerSafeMessageHash)

Expand Down

0 comments on commit bbfe4c9

Please sign in to comment.