Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build kits with cjs and esm targets #1023

Closed
wants to merge 1 commit into from
Closed

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Oct 23, 2024

What it solves

Resolves #

How this PR fixes it

@dasanra dasanra changed the base branch from main to development October 23, 2024 14:14
@frontendphil
Copy link

frontendphil commented Nov 1, 2024

I see that something seems off with this PR. Would it help if I opened up another PR that not only updates the build for protocol-kit but also takes a swing at all the builds in the reop? Building through tsc is pretty memory-heavy and can be done much faster with esbuild. So, I could replicate the setup I added to the protocol-kit and add it to all the packages. WDYT?

@frontendphil
Copy link

I've opened up another PR that addresses this topic with an extended scope. Would be great if you could have a look: #1047

This PR is obsolete now.

@dasanra dasanra closed this Nov 15, 2024
@dasanra dasanra deleted the esm-bundle branch November 15, 2024 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants