Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SignatureType type #1061

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat: add SignatureType type #1061

merged 2 commits into from
Dec 2, 2024

Conversation

DaniSomoza
Copy link
Contributor

What it solves

based on this suggestion: #1043

How this PR fixes it

export const SignatureTypes = {
  CONTRACT_SIGNATURE: 'CONTRACT_SIGNATURE',
  EOA: 'EOA',
  APPROVED_HASH: 'APPROVED_HASH',
  ETH_SIGN: 'ETH_SIGN'
} as const

export type SignatureType = (typeof SignatureTypes)[keyof typeof SignatureTypes]

@DaniSomoza DaniSomoza requested a review from yagopv November 28, 2024 16:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12072824726

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.476%

Totals Coverage Status
Change from base Build 12008934309: 0.02%
Covered Lines: 789
Relevant Lines: 974

💛 - Coveralls

@yagopv yagopv merged commit 535f2b8 into development Dec 2, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@yagopv yagopv deleted the add-signatureType-types branch December 4, 2024 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants