Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relay-kit): Improve Safe4337Pack paymaster types #902

Merged
merged 5 commits into from
Jul 15, 2024
Merged

feat(relay-kit): Improve Safe4337Pack paymaster types #902

merged 5 commits into from
Jul 15, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Jul 8, 2024 •
edited by dasanra
Loading

What it solves

Resolves #900 and #896

  • Added new types for paymaster options making it clear what properties to use

@yagopv yagopv changed the base branch from main to development July 8, 2024 19:59
@coveralls
Copy link

coveralls commented Jul 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9881661450

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 74.389%
Files with Coverage Reduction New Missed Lines %
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts 1 87.79%
Totals Coverage Status
Change from base Build 9809678697: -0.08%
Covered Lines: 784
Relevant Lines: 982
💛 - Coveralls

@yagopv yagopv marked this pull request as ready for review July 9, 2024 08:16
@yagopv yagopv requested review from dasanra and DaniSomoza July 9, 2024 08:27
@dasanra dasanra linked an issue Jul 15, 2024 that may be closed by this pull request
paymasterAddress is not required for sponsored transactions in the relay-kit #896
Closed
@yagopv yagopv merged commit 563b495 into development Jul 15, 2024
20 checks passed
@yagopv yagopv deleted the feat/improve-paymaster-types branch July 15, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yagopv @coveralls @dasanra