Add Additional Checks on Assets Folder #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
rmeissner,
akshay-ap,
mmv08,
remedcu,
fmrsabino,
falvaradorodriguez and
iamacook
nlordell
commented
Feb 16, 2024
| @@ -50,6 +50,7 @@ | |||
| "255": "0xB19D6FFc2182150F8Eb585b79D4ABcd7C5640A9d", | |||
| "280": "0xcB8e5E438c5c2b45FbE17B02Ca9aF91509a8ad56", | |||
| "288": "0xB19D6FFc2182150F8Eb585b79D4ABcd7C5640A9d", | |||
| "291": "0x7cbB62EaA69F79e6873cD1ecB2392971036cFAa4", | |||
There was a problem hiding this comment.
This was missing. Verified here: https://explorer.orderly.network/address/0x7cbB62EaA69F79e6873cD1ecB2392971036cFAa4?tab=contract
nlordell
commented
Feb 16, 2024
| "200101": "0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2", | ||
| "200202": "0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2", | ||
| "333999": "0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2", |
There was a problem hiding this comment.
Missing, but unable to verify. Using what the address should be based on other contracts.
nlordell
commented
Feb 16, 2024
| @@ -58,6 +58,7 @@ | |||
| "336": "0x59AD6735bCd8152B84860Cb256dD9e96b85F69Da", | |||
| "338": "0x727a77a074D1E6c4530e814F89E618a3298FC044", | |||
| "420": "0x727a77a074D1E6c4530e814F89E618a3298FC044", | |||
| "424": "0x59AD6735bCd8152B84860Cb256dD9e96b85F69Da", | |||
There was a problem hiding this comment.
Missing address, verified https://explorer.publicgoods.network/address/0x59AD6735bCd8152B84860Cb256dD9e96b85F69Da?tab=contract
nlordell
force-pushed
the
check-assets
branch
from
c83b72c to
3f0ef39
Compare
nlordell
commented
Feb 16, 2024
| @@ -144,6 +145,7 @@ | |||
| "54211": "0x727a77a074D1E6c4530e814F89E618a3298FC044", | |||
| "56288": "0x727a77a074D1E6c4530e814F89E618a3298FC044", | |||
| "57000": "0x727a77a074D1E6c4530e814F89E618a3298FC044", | |||
| "58008": "0x59AD6735bCd8152B84860Cb256dD9e96b85F69Da", | |||
There was a problem hiding this comment.
Contract is not verified, but was deployed: https://explorer.sepolia.publicgoods.network/address/0x59AD6735bCd8152B84860Cb256dD9e96b85F69Da?tab=contract
nlordell
force-pushed
the
check-assets
branch
from
3f0ef39 to
d17ac29
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional tests on the JSON files in the
assets/directory to ensure that:networkAddressesobject is orderedThis led to some changes 👇.