Do Not Add Reviewer To Version Bump PR #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
--reviewerwhen creating the version bump PR. The reason is that this was causing CI to fail with:From what I understand, this is because the automatically created GitHub token that gets injected in the GitHub actions (
github.token) is scoped to the repository and does not have org access in order to "find" the team and adding to (source).I did not catch this in my local debugging as I did not have a team to test with to add to the reviewers, so did not run into this problem.
I also took this opportunity to scope the
GH_TOKENenvironment variable to only the step that runs the release script, instead of all the steps.