feat: add 1.4.1 contracts for Hemi Sepolia #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed. I didn't check addresses before. Here are the address I have got after deployment. I have followed standard procedure, I am curious why addresses are different? "CompatibilityFallbackHandler": 0xbbf7501834895288d450a5486c66031e13410F68
"CreateCall": 0xB22D635D552eC95142E2Abe3FfB859eA7d7C0316
"MultiSendCallOnly": 0xdAf12bDB02612585B4D6C2012D5bEC86EBd138E4
"MultiSend": 0x99BF7AD8C743A3240Cc861CD6E1c51FAd97dEe3B
"SafeL2": 0x0200216A26588315deD46e5451388DfC358A5bD4
"SafeMigration": 0xD76fb39525AA4E240c87C57f6DDAcA26C6D7f30A
"SafeProxyFactory": 0x8b24df6da67319eE9638a798660547D67a29f4ce
"SafeToL2Migration": 0x83df8eC8699687C18D2D4832385bcd7150D0F745
"SafeToL2Setup": 0x5941bAEf7a31933bF00B7f5Cc0Ae6abc6E41e3f0
"Safe": 0x36F86745986cB49C0e8cB38f14e948bb82d8d1A8
"SignMessageLib": 0xc162086f93fAA03AB8aEA2441fF1fbde912d5808
"SimulateTxAccessor": 0x07EfA797c55B5DdE3698d876b277aBb6B893654C
"TokenCallbackHandler": 0x0196488150f795A8Ba45a659E12e82E653d3D91D
"ExtensibleFallbackHandler": 0x2D50d8a314ED6B95056f049F25025a8290DCd46c |
what commit did you use? |
I have deployed from main branch latest commit 129f02cdd72b7af806d90a622959f42d6171bd70, I guess I should have used 1.4.1. Should I deploy again using 1.4.1? |
Correct |
|
@mmv08 I have deployed 1.4.1 contracts, can you try running verification process again? |
|
Could you also please deploy the safe migration contracts? Use the tag: v1.4.1-3 for deployment |
rokso
force-pushed
the
hemi-sepolia-1.4.1
branch
from
27bc8f8 to
316a3a1
Compare
rokso
force-pushed
the
hemi-sepolia-1.4.1
branch
from
316a3a1 to
840b2c8
Compare
For some reason my local setup skipped few contracts. Everything should be in place now. |
remedcu
approved these changes
Nov 16, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new chain
Please fill the following form:
Provide the Chain ID (Only 1 chain id per PR).
Provide RPC URL for the chain (should be able to query atleast 3+ requests per second for automatic PR check).
Relevant information: