You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allow SafeMessagemessage to be optional, as when indexing we only have the hash and no way to know the message for it.
Questions
Currently SafeMessage needs to have at least one signature to be POSTed to the service. Should we allow SafeMessage with no signatures so when there's an onchain signature message can be shown?
The text was updated successfully, but these errors were encountered:
What is needed?
Onchain message signatures should be indexed, same as we do for
MultisigTransaction
signatures.Background
Proposed solution
signMessage
calls: https://github.com/safe-global/safe-contracts/blob/ee92957307653ae6cf7312bbcb1a13c6884ea6ea/contracts/libraries/SignMessageLib.sol#L20SignMsg
event: https://github.com/safe-global/safe-contracts/blob/ee92957307653ae6cf7312bbcb1a13c6884ea6ea/contracts/libraries/SignMessageLib.sol#L23SafeMessage
message
to be optional, as when indexing we only have thehash
and no way to know themessage
for it.Questions
SafeMessage
needs to have at least one signature to be POSTed to the service. Should we allowSafeMessage
with no signatures so when there's an onchain signaturemessage
can be shown?The text was updated successfully, but these errors were encountered: