refactor: updated to latest expo #27
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| }, | ||
| }); |
There was a problem hiding this comment.
The code looks good as it is following the best practices for a basic React Native application. However, if you want to make it more appealing or personalized, you can change the background color and text styles. Also, adding comments to explain what each part of the code does could be helpful. Overall, great job! 👍
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@t3-oss/env-core": "^0.6.1", | |||
| "expo": "~49.0.5", | |||
| "expo": "~49.0.8", | |||
| "expo-status-bar": "~1.6.0", | |||
| "react": "18.2.0", | |||
| "react-native": "0.72.4", | |||
There was a problem hiding this comment.
👍 Overall, the code looks good with only a minor change in dependency version.
👉 My suggestion is to update expo from ~49.0.5 to ~49.0.8. This will ensure that you have the latest version of Expo SDK for your project.
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "config:base" | ||
| ] | ||
| } |
There was a problem hiding this comment.
👍 The changes in the pull request look good to me. By formatting the code into a more readable and consistent way, it makes it easier for other people to understand and maintain the code in the future. It's always a good practice to stick to one style of formatting throughout the entire codebase. Therefore, the applied change, indenting all "extends" properties to two spaces looks cleaner.
I would suggest adding a brief comment or explanation on why this change is necessary. It helps others who review your code to understand the intention behind your update.
|
|
||
| const StorybookUIRoot = getStorybookUI({}); | ||
|
|
||
| export default StorybookUIRoot; |
There was a problem hiding this comment.
👍 Overall, the code looks good. Here are a few suggestions to make it even better:
-
Consider adding comments to explain what the code does at each step. This can make it easier for others who read your code to understand its purpose.
-
It's always a good practice to adhere to a consistent coding style across the project. Consider adding semi-colons at the end of the lines to follow a consistent coding style.
-
In case this code is included in a larger project, you might want to consider making
StorybookUIRoota named export instead of a default one, which makes it easier to import it into other modules and avoids naming conflicts with other default exports.
Overall, great job! Keep up the good work! 👏
| '@storybook/addon-ondevice-controls', | ||
| '@storybook/addon-ondevice-actions', | ||
| ], | ||
| }; |
There was a problem hiding this comment.
👍 The code looks good!
One suggestion could be to add some comments explaining what each line or section of the configuration file does, so that other developers who may come across this file in the future can understand it more easily.
Also, double-check that all the necessary dependencies for the addons have been installed and added to the project's package.json file.
| <Story /> | ||
| </View> | ||
| ), | ||
| ]; |
There was a problem hiding this comment.
The code looks good. However, here are a few suggestions for improvement:
- Consider adding comments to explain what each section of the code does.
- You could use more descriptive variable names instead of shorthand names like "Story".
- Consider adding default values for the "color" and "date" matchers in the control section.
👍 Overall, great job!
| }; | ||
| }; | ||
|
|
||
| configure(getStories, module, false); |
There was a problem hiding this comment.
The code looks good to me, but I would suggest adding comments to sections where it might not be immediately evident what the purpose of certain blocks of code is. For example, a comment explaining the purpose of decorators variable and why they're being cleared might be helpful. It could help make the code easier for other developers to understand. 👍
| "include": ["src"], | ||
| "include": [ | ||
| "src" | ||
| ], | ||
| "compilerOptions": { | ||
| "strict": true, | ||
| "baseUrl": ".", |
There was a problem hiding this comment.
👍 It looks like a simple pull request that just includes the "src" folder and sets some compiler options.
My only suggestion would be to consider adding comments or explanations for any future contributors who may not be as familiar with this code. This can help them understand why certain changes were made and how they can continue to improve it.
No description provided.