SAK-49725 Portal Organize Pinned should retain the order #12357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
reviewed
Feb 8, 2024
| @@ -118,18 +118,18 @@ private void saveUserFavorites(String userId, FavoriteSites favorites, boolean r | |||
|
|
|||
| public static class FavoriteSites { | |||
|
|
|||
| private Set<String> favoriteSiteIds; | |||
| private List<String> favoriteSiteIds; | |||
There was a problem hiding this comment.
@hornersa I used a Set to avoid dealing with duplicates so I would use a LinkedHashSet vs a List to retain the order or if possible even better would be to do the ordering on the client.
There was a problem hiding this comment.
I'll force push this revision soon.
ern
changed the title
ern
reviewed
Feb 12, 2024
portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/FavoritesHandler.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Feb 12, 2024
portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/FavoritesHandler.java
Show resolved
Hide resolved
ern
reviewed
Feb 12, 2024
portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/FavoritesHandler.java
Outdated
Show resolved
Hide resolved
ern
approved these changes
Feb 12, 2024
ern
changed the title
ern
changed the title
ern
pushed a commit
that referenced
this pull request
Mar 8, 2024
Co-authored-by: Horner, Sean A <hornersa@plu.edu> Co-authored-by: Earle Nietzel <earle@longsight.com> (cherry picked from commit 2fc14f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://sakaiproject.atlassian.net/browse/SAK-49725
For the user's desired order of pinned sites to be retained, FavoriteSites.favoriteSiteIds needs to be a List instead of a Set.