Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-49766 Assignments releasing submissions should work consistently #12390

Merged
merged 4 commits into from
Feb 29, 2024
Merged

SAK-49766 Assignments releasing submissions should work consistently #12390

merged 4 commits into from
Feb 29, 2024

Conversation

ern
Copy link
Contributor

@ern ern commented Feb 20, 2024

https://sakaiproject.atlassian.net/browse/SAK-49766

  • this also removes the outdated option withGrade

@ern ern marked this pull request as ready for review February 21, 2024 15:00
ern added a commit to ern/sakai that referenced this pull request Feb 28, 2024
@ern
SAK-49766 Assignments releasing submissions should work consistently s…
3fe8dd9 
…akaiproject#12390

https://sakaiproject.atlassian.net/browse/SAK-49766
- this also removes the outdated option withGrade
accesslint[bot]
accesslint bot reviewed Feb 28, 2024
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm Show resolved Hide resolved
ottenhoff
ottenhoff approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ottenhoff ottenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've performed several hours of testing here and provided lots of feedback.

@ern ern merged commit 8a41457 into sakaiproject:master Feb 29, 2024
4 checks passed
ern added a commit that referenced this pull request Apr 5, 2024
@ern
SAK-49766 Assignments releasing submissions should work consistently (#…
da5d34a 
…12390)

(cherry picked from commit 8a41457)

 Conflicts:
	assignment/api/src/resources/assignment.properties
	assignment/api/src/resources/assignment_sr.properties
	assignment/tool/src/webapp/js/assignments.js
	assignment/tool/src/webapp/vm/assignment/chef_assignments_student_review_edit.vm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

@ottenhoff ottenhoff ottenhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ern @ottenhoff