SAK-49150 Gradebook TA not in group, but with permission to grade a group, cannot actually grade #12589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaljaykam
changed the title
ern
changed the title
adrianfish
requested changes
May 14, 2024
|
|
||
| List<String> groupReferences = perms.stream().map(PermissionDefinition::getGroupReference).collect(Collectors.toList()); | ||
|
|
||
| final Collection<Group> groups = !groupReferences.isEmpty() ? site.getGroups() : site.getGroupsWithMember(userDirectoryService.getCurrentUser().getId()); |
There was a problem hiding this comment.
If groupReferences is not empty you are returning all the groups for the site. What if the user only has permission on a subset of the site's groups?
…group, cannot actually gradesave progress
adrianfish
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-49150