Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-48398 Samigo Improve Question texts layouts inconsistency #12592

Merged
merged 2 commits into from
May 28, 2024

Conversation

kunaljaykam
Copy link
Member

@ern ern changed the title SAK-48398 Samigo: Question Text (above the ckeditor) very inconsistent between question types SAK-48398 Samigo improved consistency of question text above the ckeditor for question types May 14, 2024
@kunaljaykam kunaljaykam changed the title SAK-48398 Samigo improved consistency of question text above the ckeditor for question types SAK-48398 Samigo Improve Question texts layouts inconsistency May 16, 2024
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@kunaljaykam kunaljaykam marked this pull request as ready for review May 16, 2024 19:11
remove the label change
@ottenhoff ottenhoff merged commit ba2d0b1 into sakaiproject:master May 28, 2024
4 of 5 checks passed
ern pushed a commit that referenced this pull request Aug 28, 2024
(cherry picked from commit ba2d0b1)

 Conflicts:
	samigo/samigo-app/src/webapp/jsf/author/authorSettings.jsp
	samigo/samigo-app/src/webapp/jsf/author/item/calculatedQuestion.jsp
	samigo/samigo-app/src/webapp/jsf/author/item/fillInNumeric.jsp
	samigo/samigo-app/src/webapp/jsf/author/item/matrixChoicesSurvey.jsp
	samigo/samigo-app/src/webapp/jsf/author/item/trueFalse.jsp
	samigo/samigo-app/src/webapp/jsf/author/publishedSettings.jsp
	samigo/samigo-app/src/webapp/jsf/questionpool/addPool.jsp
	samigo/samigo-app/src/webapp/jsf/questionpool/editPool.jsp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants