Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/darkmode #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/darkmode #13

wants to merge 4 commits into from

Conversation

r-4bb1t
Copy link

@r-4bb1t r-4bb1t commented Sep 11, 2022

I modified it so that it can be used if you give the html tag a darkmode classname. There may still be some shortcomings.

@sakofchit
Copy link
Owner

sakofchit commented Sep 15, 2022

this is a good start! but it looks like it breaks a few things:

  1. default buttons don't have the black border

Screen Shot 2022-09-14 at 11 43 55 PM

  1. selected dropdown menu isn't highlighted

Screen Shot 2022-09-14 at 11 44 24 PM

  1. Darkmode scrollbar arrow svgs don't seem to display

Screen Shot 2022-09-14 at 11 46 50 PM

  1. box shadows should probably have a white offset instead of black

Screen Shot 2022-09-14 at 11 48 01 PM

@r-4bb1t
Copy link
Author

r-4bb1t commented Sep 15, 2022

I revised the contents you wrote, so I'd appreciate it if you could check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants