Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inventory preview on multi player server #1

Merged

Conversation

zly2006
Copy link

@zly2006 zly2006 commented Jun 19, 2024

In this PR, we send the vanilla nbt query packets to get server-side data of entities and block entities.

This packet requires a permission level of at least 2, however, some mods can bypass this limit, so it also works if the server admin installed those mods even you are not an op.

sakura-ryoko and others added 30 commits December 22, 2023 15:36
…lls to isLiquid() -- Perhaps move to malilib if working.
…lls to isLiquid() -- Perhaps move to malilib if working.
…ation values for flexibleBlockPlacement Grid under MaLiLib
… up some wording for the Block / Entity reach overrides with the Single Player warnings.
…e # 485 -- Mac Mouse / Trackpad issue from 0.16.1/3 + ?
@sakura-ryoko sakura-ryoko changed the base branch from pre-rewrite/fabric/1.21-DEV to pre-rewrite/fabric/1.21 June 20, 2024 06:17
@sakura-ryoko sakura-ryoko merged commit c980f89 into sakura-ryoko:pre-rewrite/fabric/1.21 Jun 20, 2024
2 checks passed
@zly2006
Copy link
Author

zly2006 commented Jun 20, 2024

@sakura-ryoko We can check if the player has permission to query server side nbt by sending a packet, maybe add another toggle for auto detecting?

@sakura-ryoko
Copy link
Owner

@sakura-ryoko We can check if the player has permission to query server side nbt by sending a packet, maybe add another toggle for auto detecting?

I have to test the code more yet, as I've been working with Litematica at the same time. When I last tried it was not functioning.

@zly2006
Copy link
Author

zly2006 commented Jun 20, 2024

I have to test the code more yet, as I've been working with Litematica at the same time. When I last tried it was not functioning.

I (and players on my server) tested it and it works with a mod that allows all nbt queries. Sorry I didn't test it with the vanilla server. But now i tested and fixed it, you can also rejoin the server to refresh your ServerDataSyncer manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants