Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the bounds more accurately on the relational implementation #109

Open
salmans opened this issue Nov 14, 2020 · 0 comments
Open

Enforce the bounds more accurately on the relational implementation #109

salmans opened this issue Nov 14, 2020 · 0 comments

Comments

@salmans
Copy link
Owner

salmans commented Nov 14, 2020

Currently the bounding a model in the relational implementation has two issues:

  • It doesn't apply the bound when adding every new observation: it keeps augmenting the new model fully at every chase-step.
  • It doesn't take the equivalence classes of elements into account when calculating the "size" of the model.

Idea:

  • keep track of model rewrites by references to elements (in Rc<RefCell<E>>).
  • compute the size of models based on the values of rewrites.
  • check the bound before adding every new observation (add the observation to the model if that particular observation doesn't violate the bound)

Originally posted by @salmans in #104 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant