Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QCDP24-26] revert back the facet to org id, and force show only the current users org #12

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

awset
Copy link

@awset awset commented Sep 19, 2024

https://salsadigital.atlassian.net/browse/QCDP24-26

Client confirmed below

  • the facet needs to be the organization of the dataset of data request
  • if current user request to other dataset that is not current user org, the org of that dataset will not appear on the facet.
  • for sysadmin, it will show all the orgs.

another changes
https://salsadigital.atlassian.net/browse/QCDP24-19
wording changes, and send out email on all fields edit, and exclude requestor if they edit their own data request

@awset awset requested a review from tino097 September 19, 2024 04:52
@awset awset self-assigned this Sep 19, 2024
Copy link
Member

@tino097 tino097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awset awset merged commit ec052d5 into develop Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants