Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby example] Fixed deeplink, created html for authorization description #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Ruby example] Fixed deeplink, created html for authorization description #36

wants to merge 1 commit into from

Conversation

baller784
Copy link
Collaborator

  • Fixed default deeplink.
  • Created HTML for authorization description.
  • Added deeplink for payment order.

ConstantinKV
ConstantinKV reviewed Mar 22, 2020
View reviewed changes
saltedge-sca-service-sinatra/app/controllers/dashboard_controller.rb
"Payment for #{amount} EUR",
"Confirm payment #{amount} EUR from account GB1234567890 to Salt Edge Payment Processor",
"Payment 256 EUR",
File.read('./public/auth.erb')
Copy link
Collaborator

@ConstantinKV ConstantinKV Mar 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth.erb is the template file, not html. Maybe better to render it and result pass to the new Authorization

@ConstantinKV ConstantinKV changed the title Fixed deeplink, created html for authorization description [Ruby example] Fixed deeplink, created html for authorization description Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConstantinKV ConstantinKV ConstantinKV left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baller784 @ConstantinKV