Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce copying and consistently use ByteBuffer #28

Open
lgrahl opened this issue Mar 13, 2019 · 0 comments
Open

Reduce copying and consistently use ByteBuffer #28

lgrahl opened this issue Mar 13, 2019 · 0 comments
Labels
enhancement

Comments

@lgrahl
Copy link
Member

lgrahl commented Mar 13, 2019

We have some APIs that expect byte[], some that expect ByteBuffer and some that can handle both. I think we can switch all of them to ByteBuffer since it's apparently cheap.

Furthermore, we copy a lot. That should be reduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgrahl